Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maven build failure with JDK23 #2882

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Fix maven build failure with JDK23 #2882

merged 1 commit into from
Oct 5, 2024

Conversation

KrnSaurabh
Copy link
Contributor

Fix maven build failure with JDK23.
Attached failure logs:
build_logs.txt

@KrnSaurabh
Copy link
Contributor Author

@pivovarit Please review.

@pivovarit
Copy link
Member

Looks good to me, but any clue why it suddenly stopped working on JDK23?

@KrnSaurabh
Copy link
Contributor Author

Not sure exactly why we need to specify AnnotationProcessor class specifically in pom file. Ideally javax.annotation.processing.Processor in Resource/META-INF should be enough for Maven to invoke Annotation Processor.

I found it from the logs that AnnotationProcessor is not being invoked and some classes were not being generated so the build was throwing compilation errors. It work when AnnotationProcessor specified in maven-compiler-plugin config.

@pivovarit
Copy link
Member

pivovarit commented Oct 5, 2024 •
edited
Loading

@KrnSaurabh I think this is the reason: https://inside.java/2024/06/18/quality-heads-up/

great job for spotting this :)

@pivovarit pivovarit merged commit 1c771ee into vavr-io:version/0.x Oct 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrnSaurabh @pivovarit